This repository was archived by the owner on Apr 6, 2026. It is now read-only.
Move to AzApi to get full exposure to devbox features#16
Merged
raffertyuy merged 18 commits intomicrosoft:mainfrom May 30, 2025
Merged
Move to AzApi to get full exposure to devbox features#16raffertyuy merged 18 commits intomicrosoft:mainfrom
raffertyuy merged 18 commits intomicrosoft:mainfrom
Conversation
… update outputs accordingly
…including enhanced identity support, new properties, and comprehensive documentation.
… update resource definitions to use AzAPI provider, and improve README documentation.
…ntity management, and add comprehensive configuration options. Update README and examples for clarity and completeness.
… features sections, improve usage examples, and ensure consistency across documentation.
…viders, modules, resources, inputs, and outputs sections for clarity and completeness.
- Removed azurerm provider configuration from provider.tf. - Deleted obsolete test files: test.tftest.hcl, README.md, and example tests. - Updated integration tests to check for resource existence instead of specific properties. - Enhanced unit tests for dev centers, projects, and resource groups with more comprehensive assertions. - Introduced a new testing guide in docs/testing.md for better clarity on test structure and execution. - Improved run_tests.sh script for better output and error handling. - Consolidated test cases for dev centers to cover various identity configurations.
… and enhance test execution steps
…n on pull requests only
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ps support - Introduced new variable `dev_center_catalogs` to define catalog configurations. - Implemented validation rules for catalog inputs, ensuring either GitHub or Azure DevOps configuration is specified. - Created a new module for Dev Center Catalogs with comprehensive tagging and sync type options. - Enhanced integration tests to validate catalog creation and configurations. - Added examples for both simple and enhanced catalog setups, demonstrating various use cases. - Updated run_tests.sh to include new unit test directories for catalog testing.
…into azapi-update
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project from the AzureRM provider to AzAPI, updates the Azure DevCenter module to use the 2025-04-01-preview API with new dev box and network settings, and enhances testing workflows and documentation.
- Migrated provider references and module implementations to AzAPI v2.4.0 and updated API version to 2025-04-01-preview.
- Expanded examples (simple and enhanced) with new DevCenter project and catalog settings.
- Consolidated and improved Terraform testing workflow and updated supporting documentation.
Reviewed Changes
Copilot reviewed 54 out of 54 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/dev_center_project/simple_case/configuration.tfvars | Added minimal example configuration for DevCenter project |
| examples/dev_center_project/simple_case/README.md | Documented usage of the simple-case DevCenter project example |
| examples/dev_center_project/enhanced_case/configuration.tfvars | Added enhanced example with full 2025-04-01-preview features |
| examples/dev_center_project/configuration.tfvars | Updated default example to include new project settings |
| examples/dev_center_environment_type/configuration.tfvars | Added display_name to environment type example |
| examples/dev_center_catalog/simple_case/configuration.tfvars | Added simple catalog example using GitHub and Azure DevOps |
| examples/dev_center_catalog/simple_case/README.md | Documented simple catalog example |
| examples/dev_center_catalog/enhanced_case/configuration.tfvars | Added enterprise-ready catalog example with tagging and secrets |
| examples/dev_center_catalog/enhanced_case/README.md | Documented enhanced catalog example |
| examples/dev_center/enhanced_case/configuration.tfvars | Added DevCenter example with preview API features |
| docs/testing.md | Introduced a comprehensive testing guide |
| dev_center_projects.tf | Switched to resource_group_id and updated module call |
| dev_center_catalogs.tf | Instantiated catalog module with AzAPI patterns |
| README.md | Added new Testing section and instructions |
| CHANGES_SUMMARY.md | Summarized API update and new features |
| .vscode/tasks.json | Added VS Code task to run all Terraform tests |
| .pre-commit-config.yaml | Swapped terraform_tfsec for terraform_trivy in hooks |
| .github/workflows/terraform-tests.yml | Upgraded Terraform version and consolidated test jobs |
| .github/copilot-instructions.md | Updated Copilot instructions to reference AzAPI v2.4.0 and naming conventions |
Comments suppressed due to low confidence (1)
tests/unit/dev_center_project/project_test.tftest.hcl:1
- Add test cases covering the new properties (
azure_ai_services_settings,catalog_settings,customization_settings, etc.) introduced in the enhanced example to ensure the module handles these settings correctly.
// run tests for dev_center_project module
1 task
…tent pull request handling
LaurentLesle
approved these changes
May 30, 2025
Contributor
LaurentLesle
left a comment
LaurentLesle
left a comment
There was a problem hiding this comment.
LGTM with all tests passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant updates to the Terraform configurations, workflows, and documentation to improve compatibility, add features, and enhance testing capabilities. The most notable changes include transitioning to the AzAPI provider, implementing the 2025-04-01-preview API for Azure DevCenter, enhancing workflows for testing, and updating documentation and best practices.
Provider Migration and Azure DevCenter Module Enhancements:
AzureRM v4.26toAzAPI v2.4.0across all configurations and documentation (.github/copilot-instructions.md). Updated references to provider documentation and resource creation examples accordingly. [1] [2]2025-04-01-previewAPI version, adding new features likedevBoxProvisioningSettings,networkSettings, and customer-managed key encryption. Ensured backward compatibility and improved identity block handling. [1] [2] [3]Workflow Improvements:
terraform v1.12.1and introduced a newcomprehensive-testsjob that consolidates unit and integration tests. Deprecated theexample-testsjob for simplicity. [1] [2]tests/run_tests.sh) and made them executable in the workflow. [1] [2]Documentation and Testing Enhancements:
.github/copilot-instructions.mdandREADME.mdto include detailed guidance on Azure API property naming conventions, testing instructions, and enhanced examples for new features. [1] [2]CHANGES_SUMMARY.md, detailing all updates to the Azure DevCenter module and their testing results.Pre-Commit and Task Configuration:
terraform_tfsecpre-commit hook withterraform_trivyfor improved security scanning..vscode/tasks.jsonto run all Terraform tests using the provided script.These updates ensure the project is aligned with the latest Azure API standards, enhances developer productivity, and maintains robust testing practices.